Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Better error reporting for CE do! #17779

Merged
merged 9 commits into from
Sep 25, 2024
Merged

Better error reporting for CE do! #17779

merged 9 commits into from
Sep 25, 2024

Conversation

edgarfgp
Copy link
Contributor

@edgarfgp edgarfgp commented Sep 23, 2024 •
edited
Loading

Description

Better ranges for CE do! error reporting. Continuation of #17671

Checklist

  • Test cases added
  • Release notes entry updated

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Sep 23, 2024 •
edited
Loading

❗ Release notes required

✅ Found changes and release notes in following paths:

Change path Release notes path Description
src/Compiler docs/release-notes/.FSharp.Compiler.Service/9.0.200.md

@edgarfgp edgarfgp marked this pull request as ready for review September 23, 2024 17:35
@edgarfgp edgarfgp requested a review from a team as a code owner September 23, 2024 17:35
@edgarfgp edgarfgp requested a review from psfinaki September 24, 2024 14:09
psfinaki
psfinaki approved these changes Sep 24, 2024
View reviewed changes
Copy link
Member

@psfinaki psfinaki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work, thanks!

@vzarytovskii vzarytovskii merged commit 6cdcc3c into dotnet:main Sep 25, 2024
32 checks passed
This was referenced Sep 25, 2024
Merged
Merged
Merged
esbenbjerre pushed a commit to esbenbjerre/fsharp that referenced this pull request Sep 30, 2024
@edgarfgp @esbenbjerre
Better error reporting for CE do! (dotnet#17779)
98f28e5 
* Better error reporting for `CE` do bang

* Use SynExpr.DoBang

* update surface area

* format code

* release notes

* update tests

* Remove no intended case
This was referenced Oct 31, 2024
Closed
Closed
@dotnet-bot dotnet-bot mentioned this pull request Nov 19, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@psfinaki psfinaki psfinaki approved these changes

@auduchinok auduchinok auduchinok approved these changes

@vzarytovskii vzarytovskii vzarytovskii approved these changes

Assignees
No one assigned
Labels
None yet
Projects
F# Compiler and Tooling
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@edgarfgp @vzarytovskii @auduchinok @psfinaki